Review new lint rules from linter 3.0 #76

Activity

1. yurii-prykhodko-solid commented on Nov 17, 2023

   

   yurii-prykhodko-solid

   on Nov 17, 2023

   Collaborator

   More actions

   • core:
     • collection_methods_unrelated_type
     • dangling_library_doc_comments
     • implicit_call_tearoffs
     • secure_pubspec_urls
     • type_literal_in_constant_pattern
     • use_string_in_part_of_directives
   • recommended:
     • unnecessary_to_list_in_spreads
     • use_super_parameters
2. yurii-prykhodko-solid commented on Nov 17, 2023

   

   yurii-prykhodko-solid

   on Nov 17, 2023

   Last edited by yurii-prykhodko-solid

   Collaborator

   More actions

   • collection_methods_unrelated_type
     • Unifies and replaces a couple lints that are now deprecated (list_remove_unrelated_type, iterable_contains_unrelated_type). We use both deprecated ones.
   • dangling_library_doc_comments
     • Pretty self-explanatory. Worth adding.
   • implicit_call_tearoffs
     • IMO very minor improvement. But Future language versions may remove the implicit call tear off.
   • secure_pubspec_urls
     • Good for the majority of cases, but some orgs rely on SSH dependencies for their apps.
   • type_literal_in_constant_pattern
     • Prevents mistyped conditionals not working. Useful, but will have to ignore when we actually need to check for bare type. That's probably gonna be rare.

     void main() {
       String f(Object? x) {
         return switch (x) {
           int => 'int type', // this will be linted with type_literal_in_constant_pattern enabled
           int _ => 'concrete int',
           _ => 'other',
         };
       }
     
       print(f(int)); // int type
       print(f(1)); // concrete int
       print(f('x')); // other
     }
     

   • unnecessary_to_list_in_spreads
     • Useful lint, potentially impactful on performance.
   • use_super_parameters
   • A bit of boilerplace reduction, would be niсe to have.
3. danylo-safonov-solid commented on Nov 27, 2023

   

   danylo-safonov-solid

   on Nov 27, 2023

   Contributor

   More actions

   FYI these are already in our analysis_options.yaml (click to jump to code)

   • collection_methods_unrelated_type
   • secure_pubspec_urls
   • unnecessary_to_list_in_spreads
   • use_super_parameters