Skip to content

Support query internal LIKE expressions [DATAJPA-292] #704

Closed

Description

@spring-projects-issues

Michael Isvy opened DATAJPA-292 and commented

Let us consider the following method:

@Query("SELECT owner FROM Owner owner WHERE owner.lastName LIKE :lastName%")
Collection<Owner> findByLastName(String lastName) throws DataAccessException;

The above code is not supported because, according to JPA, we should have something like this:

entityManager.createQuery("SELECT owner FROM Owner owner WHERE owner.lastName LIKE :lastName")
query.setParam("lastName", lastName + "%")

So the current suggested way in Spring Data is to rely on query generation using the 'StartingWith' suffix:

Collection<Owner> findByLastNameStartingWith(String lastName) throws DataAccessException;

It works, except when we'd like to use a fetch join.
It would be great to have the possibility to do this:

@Query("SELECT owner FROM Owner owner left join fetch owner.pets WHERE owner.lastName LIKE :lastName%")
Collection<Owner> findByLastName(String lastName) throws DataAccessException;

I think the best way to handle it is to add some preprocessing code so Spring Data would first search for "%" characters and add them to the parameter's value (if any)


Referenced from: commits 60c8664, d40c83d, ddd1b9e, 285a994

Activity

  1. spring-projects-issues commented on Mar 13, 2013

    @spring-projects-issues
    Author

    Oliver Drotbohm commented

    Implemented in the latest snapshots. One thing to note is that references to the same parameter can only be equipped with the very same LIKE expression. The following query snippet is invalid:

    … firstname like %?1 and lastname like ?1%
    

    As we can only bind a single parameter once

  2. spring-projects-issues commented on Apr 17, 2013

    @spring-projects-issues
    Author
  3. spring-projects-issues commented on May 3, 2013

    @spring-projects-issues
    Author

    Alex commented

    That broke backward compatibility for me!

    Older query where I passed the pattern as a parameter now does not work anymore, for example this one won't compile:

    @Query("FROM User j WHERE j.name LIKE :substring OR j.description LIKE :substring")
    Page<User> searchUsers(@Param("substring") String substring, Pageable page);
    

    Since the pattern is provided by the client (which I can't modify) I can't put it statically in the definition. Is there a workaround for this?

  4. spring-projects-issues commented on May 3, 2013

    @spring-projects-issues
    Author

    Oliver Drotbohm commented

    Any chance you open a new ticket and attach the exception you see?

  5. spring-projects-issues commented on May 3, 2013

    @spring-projects-issues
    Author

    Alex commented

    Done with DATAJPA-341, thanks

  6. added this to the 1.3.1 milestone on Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions