Skip to content

Accept ajc-compiled @Aspect classes for Spring AOP proxy usage #32793

Description

@jhoeller

In order to ship @Aspect classes for usage with Spring AOP proxies as well as AspectJ load-time and compile-time weaving, they need to be fully compiled with ajc. This is the case for Micrometer's TimedAspect: micrometer-metrics/micrometer#1149

Our isAspect() check in AbstractAspectJAdvisorFactory does not accept ajc-compiled classes since it assumes that those are classic aspect classes which are not suitable for usage with Spring AOP. Let's relax that check, we only really need isAspect() to tell us what we need to introspect; we do not need it to determine actual advice compatibility.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

in: coreIssues in core modules (aop, beans, core, context, expression)status: backportedAn issue that has been backported to maintenance branchestype: enhancementA general enhancement

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions