[ver. 1.14.0] Adapter generation fails if JsonQualifier has nested annotations #1581

Activity

1. lev-zakaryan

   added

   bug

   on Oct 31, 2022
2. lev-zakaryan commented on Mar 13, 2023

   

   lev-zakaryan

   on Mar 13, 2023

   Last edited by lev-zakaryan

   Author

   More actions

   Here is a simple test for JsonClassCodegenProcessorTest.kt to reproduce the problem in moshi 1.14:

     @Test
     fun nestedAnnotationsTest() {
       val result = compile(
         kotlin(
           "source.kt",
           """
             import com.squareup.moshi.JsonClass
             import com.squareup.moshi.JsonQualifier
             import kotlin.annotation.AnnotationRetention.RUNTIME
             import kotlin.annotation.AnnotationTarget.FIELD
             import kotlin.annotation.Retention
             import kotlin.annotation.Target
             import kotlin.reflect.KClass
   
             @JsonClass(generateAdapter = true)
             class TestAdapterClass(
                 @OuterAnnotation(
                   InnerAnnotation("first"),
                   InnerAnnotation("second"),
                   InnerAnnotation("third")
                 )
                 var param: String
             )
   
             @JsonQualifier
             @Retention(RUNTIME)
             @Target(FIELD)
             annotation class OuterAnnotation(
                 vararg val values: InnerAnnotation
             )
   
             @Retention(RUNTIME)
             @Target(FIELD)
             annotation class InnerAnnotation(val name: String)
             """,
         ),
       )
       assertThat(result.exitCode).isEqualTo(KotlinCompilation.ExitCode.OK)
     }
   
3. lev-zakaryan commented on Mar 16, 2023

   

   lev-zakaryan

   on Mar 16, 2023

   Author

   More actions

   The problem seems to appear because of commit 7355328

   Specifically, this change to DelegateKey:
   7355328#diff-38d9cd4fce3da293198ab776387c064107fd9da2b3ded024807af16cea91a12a

   This changes the output of generated output, now a set of instantiated annotations are passed to moshi instead of Types.getFieldJsonQualifierAnnotations