Repository navigation
Support R8 FullMode #1663
Description
Activity
Wanna send a PR? I'd want to see a full description of the implications of that rule and its attributes, but open to it!
Currently I just copy pasta this rule from other Android library projects, e.g. this PR which also contains a nice explanation: lysine-dev/retrofit#3579
I think this is also true for Moshi. But I am not really an expert on this topic.
Well, PR welcome but would need an explanation of the side effects. We're unlikely to accept a PR with broad proguard/R8 implications without that kind of detail.
Reacted by Thomas Wirth@DarkAbhi Nope, your stacktrace seems not to be related to Moshi, since it would run into this error: https://github.com/square/moshi/blob/1.14.0/moshi/src/main/java/com/squareup/moshi/AdapterMethodsFactory.java#L226
Reacted by Abhishek AN@DarkAbhi Nope, your stacktrace seems not to be related to Moshi, since it would run into this error: https://github.com/square/moshi/blob/1.14.0/moshi/src/main/java/com/squareup/moshi/AdapterMethodsFactory.java#L226
Right, thanks. I'm going to be running around a lot figuring this out..
Reacted by Thomas Wirth- marked Unexpected signature after migrating to KSP #1720 as a duplicate of this issue
on Oct 1, 2025 - added a commit that references this issue
on Sep 12, 2026
Currently Moshi expects JsonAdapters to have the
ParameterizedType. But the R8 fullMode (which is enabled by default since AGP8) strips signatures from non-kept items. Therefore the check in parametersAreJsonAdapters (also in the Kotlin implementation) fails because of this assumption and you run into a IllegalArgumentException at runtime.I was able to fix this by adding the following proguard rule:
-keep,allowobfuscation,allowshrinking class com.squareup.moshi.JsonAdapterI would expect this rule as part of the META-INF/proguard/moshi.pro