Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.
This repository was archived by the owner on May 12, 2021. It is now read-only.

UI: Avatar image for Profile on Light theme overflows box #1263

Description

@johanbove

See screenshot for an example.

Annotation 2020-03-12 143954

Activity

  1. johanbove commented on Mar 12, 2020

    @johanbove
    ContributorAuthor

    Currently looking into fixing this.

  2. christianbundy commented on Mar 20, 2020

    @christianbundy
    Contributor

    I think this was fixed in #1265, yeah?

  3. black-puppydog commented on Mar 20, 2020

    @black-puppydog
    Contributor

    actually, not sure if this is related, but on master I'm seeing this sort of layout right now for all profiles, not just the ones with non-square profile pics:

    Screenshot_20200321_001013

  4. christianbundy commented on Mar 21, 2020

    @christianbundy
    Contributor

    Fun! I wonder why. :/

  5. johanbove commented on Mar 21, 2020

    @johanbove
    ContributorAuthor

    Perhaps a difference between light and dark mode?

  6. johanbove commented on Mar 21, 2020

    @johanbove
    ContributorAuthor

    @black-puppydog Thanks for the bug report! Indeed, my "fix" broke that. I just managed to get Patchwork running from the source code locally on my Windows machine and I will fix this avatar issue.

  7. johanbove commented on Mar 21, 2020

    @johanbove
    ContributorAuthor

    @christianbundy Please see PR #1267

  8. added a commit that references this issue on Mar 21, 2020
  9. christianbundy commented on Mar 21, 2020

    @christianbundy
    Contributor

    Merged! Thanks for that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions