Skip to content

Add warmup_draws = T argument to read_cmdstan_csv #565

Open

Description

@jsocolar

I'd like to change read_cmdstan_csv so that I can avoid reading in warmup draws even if the model was fit with save_warmup = T. Proposed fix is to add a warmup_draws = T argument to read_cmdstan_csv. There would be no change in the default behavior, but if warmup_draws is set to F the returned object would be equivalent to the current default behavior as if the model had been fit with save_warmup = F.

Any comments/objections to me adding this?

Activity

  1. jgabry commented on Oct 5, 2021

    @jgabry
    Member

    I can't think of any problems with this, so yeah fine by me if you want to add this feature. @rok-cesnovar what do you think (and no rush, I know you're dealing with the release stuff)?

  2. rok-cesnovar commented on Oct 5, 2021

    @rok-cesnovar
    Member

    Yeah, seems reasonable to me as well.

  3. self-assigned this
    on Nov 12, 2021
  4. added this to the future milestone on Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featureNew feature or request

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions