Skip to content

Added support for NTLM Authentication in Mailer - #48267

Closed
Akasiek wants to merge 7 commits into
symfony:7.1from
Akasiek:6.3
Closed

Akasiek wants to merge 7 commits into
symfony:7.1from
Akasiek:6.3

Conversation

@Akasiek

@Akasiek Akasiek commented Nov 21, 2022

Copy link
Copy Markdown
Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #46337
License MIT
Doc PR

It is not my port, so I'm not listed as an author. I just made it work for Symfony/Mailer. Original port.

I didn't add any Doc PR because I didn't find any mention of other auth mailer options in there.

@carsonbot

Copy link
Copy Markdown

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

Copy link
Copy Markdown

Hey!

Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@Akasiek Akasiek changed the title Added support for NTLM Auth in Mailer Added support for NTLM Authentication in Mailer Nov 21, 2022
@fabpot fabpot modified the milestones: 6.2, 6.3 Nov 23, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 May 23, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@Akasiek Akasiek closed this by deleting the head repository Jan 29, 2024
@jawira

jawira commented Feb 19, 2024 •

Copy link
Copy Markdown
Contributor

@Akasiek Hello, as far I can see this PR was not merged, it's possible to re-open this please ? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"failed to find an authenticator supported by SMTP server" Supported are gssapi ntlm

5 participants