Skip to content

network: fix reconfigure - #14611

Merged
keszybz merged 3 commits into
systemd:masterfrom
yuwata:network-fix-reconfigure
Jan 28, 2020
Merged

keszybz merged 3 commits into
systemd:masterfrom
yuwata:network-fix-reconfigure

Conversation

@yuwata

@yuwata yuwata commented Jan 20, 2020

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, aren't we updating the link state file synchronously before returning in the bus call?

@poettering poettering added the needs-reporter-feedback ❓ There's an unanswered question, the reporter needs to answer label Jan 21, 2020
@yuwata
yuwata force-pushed the network-fix-reconfigure branch from c64da35 to 2c0d7ed Compare January 22, 2020 07:08
@yuwata yuwata removed the needs-reporter-feedback ❓ There's an unanswered question, the reporter needs to answer label Jan 22, 2020
@yuwata

yuwata commented Jan 22, 2020

Copy link
Copy Markdown
Member Author

@poettering Thank you for the comment. Now networkd synchronously write state files on reconfigure. PTAL.

@yuwata yuwata removed the tests label Jan 22, 2020
@keszybz

keszybz commented Jan 28, 2020

Copy link
Copy Markdown
Member

Looks reasonable.

@keszybz
keszybz merged commit ebe2ab6 into systemd:master Jan 28, 2020
@yuwata
yuwata deleted the network-fix-reconfigure branch January 28, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants