Repository navigation
Protect clock - #14673
Merged
Merged
Protect clock#14673
Conversation
Member
|
Please also update docs/TRANSIENT-SETTINGS.md. |
kkuehlz
force-pushed
the
protect_clock
branch
from
January 27, 2020 19:21
403ad83 to
022d334
Compare
Member
|
Excellent! Tried hard to find something to complain about, but couldn't find anything. @keur, awesome work! |
Contributor
Author
|
Thanks! We can add tests for this, but I'll add them after #14548 is worked out. |
Member
|
A test would be great. And so would be a follow-up patch that turns this option on for all our long-running services where that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.