Skip to content

network: rename eui64 to static - #14805

Merged
keszybz merged 2 commits into
systemd:masterfrom
yuwata:network-ipv6-token-follow-up
Feb 7, 2020
Merged

keszybz merged 2 commits into
systemd:masterfrom
yuwata:network-ipv6-token-follow-up

Conversation

@yuwata

@yuwata yuwata commented Feb 6, 2020

Copy link
Copy Markdown
Member

See RFC 4291.

Follow-up for 5f506a5.

cc @kpfleming, @ssahani and @keszybz.

@keszybz

keszybz commented Feb 6, 2020

Copy link
Copy Markdown
Member

I misunderstood what the options were supposed to mean. Let's wait for @kpfleming's review who seems to understand this better.

See RFC 4291.

Follow-up for 5f506a5.
@evverx

evverx commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

@yuwata I think to make sure #14811 is gone, "eui64" should be replaced with "static" in test/fuzz/fuzz-network-parser/oss-fuzz-20548 as well.

Fixes systemd#14811 and oss-fuzz#20548.
@yuwata

yuwata commented Feb 7, 2020

Copy link
Copy Markdown
Member Author

@evverx Updated.

@yuwata
yuwata force-pushed the network-ipv6-token-follow-up branch from cdd70f3 to f0c1ad3 Compare February 7, 2020 08:20
@yuwata yuwata added this to the v245 milestone Feb 7, 2020
@kpfleming

Copy link
Copy Markdown
Contributor

This is very promising! Thanks for the quick response.

In 'eui64' mode should the user still be allowed to specify an address? It seems like that is unnecessary, as the user has explicitly requested automatic generation of the IID using the EUI-64 method.

I'm also still happy to improve the documentation before this is merged; I can send a PR to @yuwata's branch if that's the simplest way to get that done.

@yuwata

yuwata commented Feb 7, 2020

Copy link
Copy Markdown
Member Author

Thanks. Improvement is always welcome.

@keszybz

keszybz commented Feb 7, 2020

Copy link
Copy Markdown
Member

Let's merge this since it fixes a crash. @kpfleming we still have a few days before the next release to fix any outstanding issues.

@keszybz
keszybz merged commit c3b41d8 into systemd:master Feb 7, 2020
@yuwata
yuwata deleted the network-ipv6-token-follow-up branch February 8, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants