Repository navigation
test: clarify that ordered_set_put() returns -EEXIST if entry is duplicated - #16561
Merged
Merged
Conversation
This API is a complete mess. We forgot to do a hashed comparison for duplicate entries and we use a direct pointer comparison. For trivial_hash_ops the result is the same. For all other case, it's not. Fixing this properly will require auditing all the uses of set_put() and ordered_set_put(). For now, let's just acknowledge the breakage.
keszybz
added
the
good-to-merge/waiting-for-ci 👍
Member
|
Not much to discuss here, let's merge this when CI passes. |
Member
Author
|
@keszybz Thank you for the follow-up commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.