test: fixed negative checks in TEST-70-TPM2 - #27079

Please write a proper commit message

Done sir.

Please use a more descriptive commit message, it's too generic, check the git log for examples

Please use a more descriptive commit message, it's too generic, check the git log for examples

Alright sir.

Please use a more descriptive commit message, it's too generic, check the git log for examples

I'm looking at using this commit message:
"fixed 27020 to use in-line error handling rather than redirections"
Is it okay sir?

test: fix negative checks in TEST-70

Use in-line error handling rather than redirections.

Follow-up for #27020

test: fix negative checks in TEST-70

Use in-line error handling rather than redirections.

Follow-up for #27020

Wow.. Thank you so much sir.

@daandemeyer @bluca, commit message fixed sirs.

It's not fixed, you've changed the PR description, but the git commit is still the same

My old commit message was "removed redirections to grep" sir.

this is what i changed to:

Then I added this to the PR descrition at the top:

Yes, the ask is to use a better commit message, like the one I shared, so please amend it and push again

test: fix negative checks in TEST-70

I used this in the PR description.

Use in-line error handling rather than redirections.

This in the commit message

Follow-up for #27020
and this at the top of the conversation sir.

Yes, the ask is to use a better commit message, like the one I shared, so please amend it and push again

Sorry for making this drag for too long sir.
"Use in-line error handling rather than redirections. Follow up on #27020"

right?

You can see the commit message here:

b26772b

Yes, the ask is to use a better commit message, like the one I shared, so please amend it and push again

Sorry for making this drag for too long sir. "Use in-line error handling rather than redirections. Follow up on #27020"

right?

Make it match the PR title and description, with the title as the first line

Yes, the ask is to use a better commit message, like the one I shared, so please amend it and push again

Sorry for making this drag for too long sir. "Use in-line error handling rather than redirections. Follow up on #27020"
right?

Make it match the PR title and description, with the title as the first line

I have made the update sir. Thank you for the guidance.
I appreciate the fact that the coding standards are this high, it's being a good experience.

Is the current commit message good to fly? Does it yet need some fixes?

almost - it's all in a single line, split it after the first period

almost - it's all in a single line, split it after the first period

Awesome.

almost - it's all in a single line, split it after the first period

How about now sir?
Can I say "I've learnt something today"? or I still need to learn a little more?