Repository navigation
analyze: add new verb "smbios11" for listing passed smbios type #11 strings - #32810
Conversation
|
Would it make sense to have the tool optionally emit machine parsable output (ie omit the trailing log message)? |
that goes to stderr anyway (unlike the strings themselves) and you can always use SYSTEMD_LOG_TARGET=null... |
github-actions
Bot
added
documentation
build-system
util-lib
meson
please-review
|
Right. I didn't pay attention to how the command is implemented, I just inferred from the documentation. Thanks! |
|
Note We had successfully released a new major release. We are no longer in a development freeze phase. |
82d1206 to
12600ef
Compare
|
new version pushed, ptal |
yuwata
left a comment
yuwata
left a comment
There was a problem hiding this comment.
LGTM.
Please add simple coverage tests for the new command.
yuwata
added
good-to-merge/after-next-release
good-to-merge/with-minor-suggestions
and removed
please-review
btw, the message is now also suppressed if you add "-q" or "--quiet" to the cmdline |
done |
12600ef to
1e6a0c5
Compare
I find myself wanting to check this data with a quick command, and browsing through /sys/ manually getting binary data sucks. Hence let's do add a nice little analysis tool.
1e6a0c5 to
99db1c9
Compare
poettering
added
good-to-merge/waiting-for-ci 👍
github-actions
Bot
removed
the
good-to-merge/waiting-for-ci 👍
4 participants
There's no nice way to query this otherwise with default distro tools