Skip to content

Create tf.substr Op #4232

Closed
Closed
Create tf.substr Op#4232
Labels
stat:contribution welcomeStatus - Contributions welcometype:featureFeature requests

Description

@samjabrahams
samjabrahams
opened on Sep 6, 2016

Would be useful for a number of purposes, such as extracting data, substring matches (#4009), etc. Proposed API (matches C++ style substrings):

Args:
  inputs: a `Tensor` of type `string`. The strings that will have substrings extracted
  pos: `int32` or `int64` `Tensor`. Position of the first character to be copied as a substring
  len: `int32` or `int64` `Tensor`. Number of characters to include in the substring

Returns:
  A `Tensor` of type `string` containing substrings of `inputs`

Activity

  1. girving
    added
    enhancement
    stat:contribution welcomeStatus - Contributions welcome
    on Sep 6, 2016

  2. DjangoPeng commented on Sep 14, 2016

    @DjangoPeng
    DjangoPeng
    on Sep 14, 2016
    Contributor

    @samjabrahams I want to try adding the substr Op :). Should I add it to the String_ops.py?

  3. samjabrahams commented on Sep 14, 2016

    @samjabrahams
    samjabrahams
    on Sep 14, 2016
    ContributorAuthor

    @DjangoPeng Oh no! I already sent in a PR two days ago with #4338. I'm planning on using the Op to finish work on the tf.decode_image Op, so I knocked out a version over the weekend.

  4. DjangoPeng commented on Sep 15, 2016

    @DjangoPeng
    DjangoPeng
    on Sep 15, 2016
    Contributor

    @samjabrahams Sounds good~ Look forward to your update~

  5. samjabrahams commented on Nov 4, 2016

    @samjabrahams
    samjabrahams
    on Nov 4, 2016
    ContributorAuthor

    Substr (#4338) has been merged into master

  6. samjabrahams
    closed this as completedon Nov 4, 2016
  7. aselle
    added
    type:featureFeature requests
    and removed
    enhancement
    on Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stat:contribution welcomeStatus - Contributions welcometype:featureFeature requests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions