Skip to content

Pylint disable should be followed by enable #5309

Description

@z-a-f

There is a problem, which might have high severity:

A lot of files disable pylint messages, but don't enable them in the end -- this potentially might cause a missed warning if several files are imported, because # pylint disable is a global disable.

Here are all the files that modify the pylint related to the wildcard-import
Here is an example file that doesn't revert the modifications

There might be other wildcards that are disabled without reverting the changes

Activity

  1. assigned and unassigned on Oct 31, 2016
  2. drpngx commented on Oct 31, 2016

    @drpngx
    Contributor

    Do you have a PR that you could send?

  3. z-a-f commented on Oct 31, 2016

    @z-a-f
    Author

    I don't -- I might be able to look into the fix over the weekend

  4. drpngx commented on Oct 31, 2016

    @drpngx
    Contributor

    Feel free to send CC me on the PR when you're ready! Thanks.

  5. added a commit that references this issue on Nov 14, 2016
    cb2ef58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions