tf.reshape accepts Dimension objects for the shape parameter - #12127

Can one of the admins verify this patch?

@facaiy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @keveman, @vrv and @tensorflower-gardener to be potential reviewers.

Sorry I don't understand the motivation
compat.as_bytes(x.str()) instead of compat.as_bytes(x)

what does this improve?

@yaroslavvb , the PR is modified as suggested by @pmccarter . But I am not sure whether it is implemented correctly, could you give more feedback? Thanks.

@tensorflow-jenkins test this please

@facaiy As you can see here: https://ci.tensorflow.org/job/tensorflow-pull-requests-cpu/6320/consoleFull
this breaks a large number of tests. I'll let @martinwicke give detailed comments.

@rmlarsen @martinwicke It'll be really useful for me if I can check test.log of CI. Because my laptop is left on office, hence I'll check it later. Thanks very much!

@tensorflow-jenkins test this please

Hi, @rmlarsen . I submit a fix, and could you help retest the PR? Thanks.

By the way, since reshape is migrated from _gen_array_op to array_op, should we remove the duplicate document of _gen_array_op._reshape? If I understand correctly, the description is in the tensorflow/core/ops/ops.pbtxt

@facaiy The docs are inside cc file which defines reshape op.

To think of it, this approach would trigger an API review. I wonder if there's a simple solution which would only touch a couple of lines of Python code, better chance of being accepted without a lot of work on maintaining team. BTW, the best way to test things is to run all relevant tests locally first, using "bazel test"

Thanks for your explanation, @yaroslavvb .

I agree that migrating reshape will introduce duplicate code and increase maintain cost, so I'd like to try to fix it in tensor_util.make_tensor_proto as well. If success, another PR will be opened, see #12513 .

Anyway, if you have any new idea / suggestion, please tell me. I'd like to take a try.

Running all test locally is time-consuming, hence only several unit tests are selected by me to be tested at first. By the way, could you tell me how to run doctest? Thanks.