Repository navigation
convert Dimension to Int for sparse_merge in _IndicatorColumn - #12558
Merged
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
ghost
approved these changes
Aug 25, 2017
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This looks good. Thanks for contributing a fix!
Member
Author
|
Thanks for you approval, @000drax ! |
1 of 2 tasks
Contributor
|
Jenkins, test this please. |
alextp
approved these changes
Aug 25, 2017
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is aimed to fix #12557 .
sparse_mergecannot handleDimension, hence casting Dimension to int when invoked.How to test