Skip to content

Fix unstable test case for Select op - #15807

Merged
caisq merged 2 commits into
tensorflow:masterfrom
facaiy:TMP/revert_select_grad
Jan 4, 2018
Merged

Fix unstable test case for Select op#15807
caisq merged 2 commits into
tensorflow:masterfrom
facaiy:TMP/revert_select_grad

Conversation

@facaiy

@facaiy facaiy commented Jan 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Fix #14862. CF: #15764

In the test case for Select op, the condition might switch to another value when x1 is close to x2. The PR is opened to resolve the unstable condition.

Test passed for 100 times.

[facai@h1077922 tensorflow]$ bazel test --runs_per_test=100 -c opt //tensorflow/cc:gradients_math_grad_test
HEAD is now at c642574... TST: modify unstable test case
INFO: Found 1 test target...
Target //tensorflow/cc:gradients_math_grad_test up-to-date:
  bazel-bin/tensorflow/cc/gradients_math_grad_test
INFO: Elapsed time: 49.959s, Critical Path: 21.29s
//tensorflow/cc:gradients_math_grad_test                                 PASSED in 21.3s
  Stats over 100 runs: max = 21.3s, min = 0.7s, avg = 11.2s, dev = 4.4s

Executed 1 out of 1 test: 1 test passes.

cc @gunan @drpngx

@tensorflow-jenkins

tensorflow-jenkins commented Jan 3, 2018

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@facaiy
facaiy force-pushed the TMP/revert_select_grad branch from c642574 to 41dc78d Compare January 3, 2018 07:00
@facaiy facaiy mentioned this pull request Jan 3, 2018
Merged
1 of 2 tasks
@caisq
caisq requested a review from drpngx January 3, 2018 18:46
@caisq caisq self-assigned this Jan 3, 2018
@caisq caisq added the awaiting review Pull request awaiting review label Jan 3, 2018
@caisq
caisq requested a review from suharshs January 3, 2018 18:46
@drpngx drpngx added awaiting testing (then merge) kokoro:force-run Tests on submitted change and removed awaiting review Pull request awaiting review labels Jan 3, 2018
@drpngx

drpngx commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 3, 2018
@facaiy

facaiy commented Jan 4, 2018

Copy link
Copy Markdown
Member Author

Thank you, @drpngx . Let's take care.

Unbutu Python3 failed:
//tensorflow/python/keras:data_utils_test: Time out

Could you retest it?

@drpngx drpngx added the kokoro:force-run Tests on submitted change label Jan 4, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 4, 2018
@drpngx

drpngx commented Jan 4, 2018

Copy link
Copy Markdown
Contributor

Thanks for pinging! Restarted.

@caisq
caisq merged commit 6db014b into tensorflow:master Jan 4, 2018
@facaiy
facaiy deleted the TMP/revert_select_grad branch January 4, 2018 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suharshs suharshs Awaiting requested review from suharshs
1 more reviewer
@drpngx drpngx drpngx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@caisq caisq

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@facaiy @tensorflow-jenkins @drpngx @googlebot @caisq @kokoro-team