Repository navigation
opencv interop fix: exclude libjpeg symbols from libtensorflow_framew… - #19966
Merged
Merged
Conversation
…ork.so to avoid symbol conflict
allenlavoie
previously approved these changes
Jun 14, 2018
allenlavoie
left a comment
allenlavoie
left a comment
Member
There was a problem hiding this comment.
Neat! Looks good to me. It'd be nice to have this on MacOS too, but we can follow up if/when someone complains.
(Assuming the tests pass. It does look like we re-export most symbols under tensorflow::jpeg::*, so it seems fine)
allenlavoie
approved these changes
Jun 14, 2018
allenlavoie
left a comment
allenlavoie
left a comment
Member
There was a problem hiding this comment.
Fixed a linter issue so we can see if the substantive tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ork.so to avoid symbol conflict