Repository navigation
OpenCL Improvements - #7596
OpenCL Improvements#7596
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
|
||
| void *SYCLAllocator::AllocateRaw(size_t alignment, size_t num_bytes) { | ||
| assert(device_); | ||
| if(num_bytes == 0) { |
There was a problem hiding this comment.
can you run clang-format over all these files?
|
@pelmers can you sign the CLA with the email you used in your git commit? Our bot surprisingly didn't flag this. I believe the others are repeat commiters so we don't need their explicit acknowldgement in every PR (so I've been told). |
|
also lots of failures, but I assume you're looking at that. |
|
@vrv submitted my CLA |
|
Cool, confirmed, thanks! |
|
Same for @krikru |
|
I signed it. |
|
@lukeiwanski thanks -- you're a repeat contributor so no need to respond in the future :) signcla bot is actually broken for this PR for some reason, i just manually inspected the emails of the others and found they weren't signed. |
|
@vrv sorry didn't notice your previous post :) |
Added Tile, Transpose and Range Ops double support for SYCL device. Moved gpu_device_name() to test_util.py so now it can be used in force_gpu to pull either GPU or SYCL depending on what is available in the system.
- Registration of Type Traits required for stride slice op - Registration of ConcatOffset, _ListToArray, _ArrayToList Pad, Reverse ( CPU ), ReverseV2 ( CPU ), Size, ExpandDims, Squeeze, StridedSlice, StridedSliceGrad, StridedSliceAssign, TileGrad, InvertPermutation, Transpose - Registration of Sycl kernels only for essential data types - Floor_div_real has been disabled for SYCL device - Device in control_flow_ops_py_test.py needed to be lower cased
* Improvements to the SYCL device support This commit reduces number of failing tests when TensorFlow compiles for OpenCL support. - Registration of Type Traits required for stride slice op - Registration of ConcatOffset, _ListToArray, _ArrayToList Pad, Reverse ( CPU ), ReverseV2 ( CPU ), Size, ExpandDims, Squeeze, StridedSlice, StridedSliceGrad, StridedSliceAssign, TileGrad, InvertPermutation, Transpose - Registration of Sycl kernels only for essential data types - Floor_div_real has been disabled for SYCL device - Device in control_flow_ops_py_test.py needed to be lower cased
unbuntu -> ubuntu
* Add ComputeCpp lib folder to LD_LIBRARY_PATH * Add ImportError problem + solution If you get the error message "ImportError: libComputeCpp.so: cannot open shared object file: No such file or directory", make sure you have added the path to ComputeCpp's lib folder to your `LD_LIBRARY_PATH`. * Add another ImportError problem + solution If you get the error message "ImportError: cannot import name 'pywrap_tensorflow'" you may be standing in the TensorFlow directory.
* Registers FloorDiv, FloorMod and SoftMax Ops for SYCL device
- Eigen version bump - Extends Cast and Cwise ops benchmark to cover Sycl device - Extends device_lib_test.py to cover Sycl device - Registers int32, string and ResourceHandler to run on host for Enter and RefEnter Sycl Ops - Enables RecudeMax op for Sycl since Eigen implementation is ready - Registers Less op for Sycl device
66fa0e1 to
e734770
Compare
placement on a gpu device even if none is detected.
|
Still need @krikru to sign the CLA under the git commit email he used and then we can merge. |
|
Signed! |
|
Did you sign with "[email protected]" ? that's what you used in your git commit, and I don't see that email registered. |
|
PS: I've used this script with success to change email when my git commits had wrong email address -- https://help.github.com/articles/changing-author-info/ |
|
@vrv Ah, no, I signed with another email address which I'm going to use on GitHub from here on. I created a new pull request from my fork of tensorflow-opencl into tensorflow-opencl in which I have changed the email of my commits to the one I signed the CLA with. Does that work? |
|
I suspect that unless that email shows up here via Benoit's push, it won't work. :( Perhaps you could tell Benoit to git commit --amend your commit with the correct email? |
|
Now I've sent @benoitsteiner an email. |
|
Validated the email addresses manually. |
7 participants
No description provided.