Repository navigation
axe_data does not remove pre$mold$extras #205
Description
The axe_data.workflow() function does not remove the mold$extras like it does for outcomes and predictors. If a column of data is set to be another role, the model will retain all of that data. Would it be OK to also remove pre$mold$extras or was it intentionally retained for predictions?
The 'outcomes' and 'predictors' are removed here.
axe_data.workflow <- function(x, verbose = FALSE, ...) {
fit <- extract_fit_parsnip(x)
fit <- butcher::axe_data(fit, verbose = verbose, ...)
x <- replace_workflow_fit(x, fit)
x <- replace_workflow_outcomes(x, NULL)
x <- replace_workflow_predictors(x, NULL)
add_butcher_class(x)
}
Activity
EmilHvitfeldt commentedon Jun 30, 2023
Removing
extrasmakes sense to me.according to
?axe_data.workflowit reads:And I don't see
$pre$mold$extrasbeing used for prediction right nowera127 commentedon Jul 1, 2023
Would the code change be similar to the others and add a new function call to set $extras to NULL:
or would we want to preserve $extras$offset, $extras$id or extras$case_weights. I'm not sure I fully understand the use of those roles.
EmilHvitfeldt commentedon Jul 1, 2023
@simonpcouch should be able to confirm. But I'm pretty sure we don't need them for prediction