Repository navigation
feat: add repeatable --custom-config option (adapted from #15) - #20
Merged
Merged
Conversation
Runs a scripts/config directive during the kernel configuration phase; the option can be passed multiple times. Adapted from the contribution by Orsiris de Jong in tmiland#15: the VERSION bump from the original PR was dropped, review fixes follow in the next commit.
- fail fast when a directive is not a scripts/config invocation: a raw CONFIG_X=y assignment was silently ignored by eval - use require_arg + shift 2 so a missing value errors out - drop the no-op sanitize layer and iterate CUSTOM_CONFIG_OPTIONS directly (shellcheck SC2116/SC2128) - README: fix unbalanced backtick, document the accepted directive form
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the request from #14, adapted from @deajan's #15 (his commits cherry-picked, authorship preserved).
Differences from the original PR:
VERSIONbump dropped (unrelated to the feature)require_arg+shift 2house pattern — a missing value now errors out instead of being silently acceptedscripts/configinvocation — a rawCONFIG_X=ywas silently ignored byevalFull CI matrix runs here (the original PR predates the CI changes on main).