Investigate better SVG code parsing

Maybe use https://github.com/WebReflection/linkedom for

Lines 69 to 88 in 1def07e

    
                   svg = svg.replace( 
        
                     'fill="#000000" stroke="none"', 
        
                     `fill="rgb(${r},${g},${b})" stroke="rgb(${r},${g},${b})"${ 
        
                       a === '255' 
        
                         ? '' 
        
                         : ` fill-opacity="${alpha}" stroke-opacity="${alpha}"` 
        
                     } stroke-width="${params.strokeWidth}px"`, 
        
                   ); 
        
                   const pathRegEx = /<path\s*d="([^"]+)"\/>/g; 
        
                   let matches; 
        
                   const shortPaths = []; 
        
                   while ((matches = pathRegEx.exec(svg)) !== null) { 
        
                     const path = matches[1]; 
        
                     if (path.split(' ').length < params.minPathSegments) { 
        
                       shortPaths.push(matches[0]); 
        
                     } 
        
                   } 
        
                   shortPaths.forEach((path) => { 
        
                     svg = svg.replace(path, ''); 
        
                   });

.

Well done, really great job... I'm interested in improving the performance/speed of this tool, do you have any pointers where I should start from?

The present issue is purely about replacing string-based replacement with proper DOM parsing.

If you are interested in improving the performance: see tomayac/esm-potrace-wasm#8. The latest version of esm-potrace-wasm is capable of dealing with color, but fails on too large inputs.

Navigation Menu

Repository navigation

Investigate better SVG code parsing #49

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	svg = svg.replace(
	'fill="#000000" stroke="none"',
	`fill="rgb(${r},${g},${b})" stroke="rgb(${r},${g},${b})"${
	a === '255'
	? ''
	: ` fill-opacity="${alpha}" stroke-opacity="${alpha}"`
	} stroke-width="${params.strokeWidth}px"`,
	);
	const pathRegEx = /<path\s*d="([^"]+)"\/>/g;
	let matches;
	const shortPaths = [];
	while ((matches = pathRegEx.exec(svg)) !== null) {
	const path = matches[1];
	if (path.split(' ').length < params.minPathSegments) {
	shortPaths.push(matches[0]);
	}
	}
	shortPaths.forEach((path) => {
	svg = svg.replace(path, '');
	});

Investigate better SVG code parsing #49

Description

Activity

xwiz commented on Aug 24, 2022

tomayac commented on Aug 24, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions