Repository navigation
Bugfix, minor functional/internal changes, linting, formatting & packaging updates and GitHub action to run PR lint/typing tests - #10
Merged
Conversation
JedMeister
force-pushed
the
minor-update
branch
2 times, most recently
from
June 8, 2026 23:22
38598f0 to
ddbc78f
Compare
JedMeister
changed the title
OnGle
reviewed
Jun 10, 2026
Comment on lines
+82
to
+83
| # allow use of "magic values" rather than enforcing use of constants | ||
| "PLR2004" |
Member
There was a problem hiding this comment.
What's the justification for this?
Member
Author
There was a problem hiding this comment.
I've removed the rule from pyproject.toml and added a noqa to the specific line : 711119d. Hopefully that answers your question and/or addresses your concern?!
71 of 72 tasks
Member
Author
|
Adjustment as requested by @OnGle (hopefully?!). Plus:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry that this is such a large diff and the misleading branch name - it started fairly minor and grew...
Bugfix handling of
--stringargument.Minimal functional/internal changes:
rootfsarg when initializingAppVerinstance now defaults toNoneAppVer.deb_codenameis now a@property- now it only gather the info (vialsb_release) if/whendeb_codenameis explicitly accessed.Linting, formatting and packaging updates. Significant code changes, but no functional change:
.rst=>.md.gitignoreto ignore common build assets and cached filessetup.py=>pyproject.tomlpython packagingpyproject.toml.4.0.0=>4.7.2)10=>13) & declaration (compatfile =>debhelper-compat (= 13)dependency)pyproject.tomlpackaging and general modernization)3.5=>3.13) (probably still works with older versions...)copyrightfile (format, license wording and copyright holder)Added simple GitHub action to run typing and linting checks on future PRs.