Skip to content

fix(eslint-plugin): [unified-signatures] allow overloads with different named and different number of parameters - #6877

Merged
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
NotWoods:unified-signatures-different-names
Apr 10, 2023
Merged

fix(eslint-plugin): [unified-signatures] allow overloads with different named and different number of parameters#6877
JoshuaKGoldberg merged 1 commit into
typescript-eslint:mainfrom
NotWoods:unified-signatures-different-names

Conversation

@NotWoods

@NotWoods NotWoods commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Allows explicit different names with overloads where the number of parameters differ.

@typescript-eslint

typescript-eslint Bot commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR, @NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify

netlify Bot commented Apr 10, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fa4848e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64339aee437d9e0008cf4446
😎 Deploy Preview https://deploy-preview-6877--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud

nx-cloud Bot commented Apr 10, 2023 •
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa4848e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@codecov

codecov Bot commented Apr 10, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6877 (fa4848e) into main (f0f83ce) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6877      +/-   ##
==========================================
- Coverage   87.36%   87.36%   -0.01%     
==========================================
  Files         386      386              
  Lines       13190    13189       -1     
  Branches     3867     3866       -1     
==========================================
- Hits        11524    11523       -1     
  Misses       1300     1300              
  Partials      366      366
Flag Coverage Δ
unittest 87.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/unified-signatures.ts 92.05% <100.00%> (-0.06%) ⬇️

@bradzacher bradzacher added the bug Something isn't working label Apr 10, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 10, 2023
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks again @NotWoods!

@JoshuaKGoldberg
JoshuaKGoldberg merged commit 939d665 into typescript-eslint:main Apr 10, 2023
@NotWoods
NotWoods deleted the unified-signatures-different-names branch April 10, 2023 16:10
@bradzacher bradzacher mentioned this pull request Apr 11, 2023
Closed
4 tasks done
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [unified-signatures] overloads with differently named parameters are still reported when other parameters are present

3 participants

@NotWoods @JoshuaKGoldberg @bradzacher