Repository navigation
Update base image in Dockerfile to latest version, add note on user - #220
Merged
Merged
Conversation
umputun
reviewed
Mar 16, 2025
|
|
||
|
|
||
| FROM ghcr.io/umputun/baseimage/app:v1.12.0 as base | ||
| FROM ghcr.io/umputun/baseimage/app:latest as base |
Owner
There was a problem hiding this comment.
I’d rather have the tagged version here instead of the latest. You know how sometimes incompatible changes sneak in and cause unexpected results? Well, for something as fundamental as this, it’s worth the extra effort to maintain compatibility.
Contributor
Author
There was a problem hiding this comment.
In this case it makes no sense as we only copying certificate and timezone files from the base image, but I pinned it to v1.15.0 instead in the new version of the commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.