Question: Why are custom replacements ran twice?

I noticed this block

     if replacements:
        for old, new in replacements:
            text = text.replace(old, new)

appears twice in slugify. Why is that? Would it not make sense to have some pre-replacements and post-replacements instead?

Test with care, some post slugify strings may end up with replacement words after the conversion, specially in non-english languages.

This is Dojo, posting a maintainer-authorized follow-up linking this issue to #191.

The two-pass contract is documented and explicit pre/post stages are available. Replacement iterator snapshot/replay changes require modern mode.

The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion.

🚀 Generated with Dojo ⛩️

Navigation Menu

Repository navigation

Question: Why are custom replacements ran twice? #119

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Question: Why are custom replacements ran twice? #119

Description

Activity

un33k commented on Sep 27, 2022

un33k commented on Sep 8, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions