Repository navigation
fix(preset-attributify): prevent backtick match from spanning lines in elementRE - #5286
Merged
zyyv merged 2 commits intoAug 31, 2026
Merged
Conversation
…n elementRE An attribute like c="red" was not extracted when a nearby line contained a backtick (e.g. a JSX template literal) together with a stray quote. The backtick alternative in elementRE matched across newlines, so an unclosed backtick on one line jumped to a backtick on a later line, swallowing the attributes in between. Restrict the backtick alternative to a single line. Template literals inside an element's opening tag never legitimately span lines, so this scopes the match without affecting valid usage; the quote and brace alternatives are untouched, preserving multiline attribute support. Closes unocss#4818
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
zyyv
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4818. In
presetAttributify, an attribute likec="red"was not extracted when a nearby line contained a backtick (e.g. a JSXid={`${a}`}) together with a stray quote. The backtick alternative inelementREmatched across newlines, so an unclosed backtick on one line jumped to a backtick on a later line, swallowing everything in between — including thec="red"attribute.Fix
Restrict the backtick alternative in
elementREto a single line by adding\nto its negated class. A template literal inside an element's opening tag never legitimately spans lines (real JSX cases likeid={`${a}`}stay on one line), so this scopes the match without affecting valid usage. The single/double-quote and{}alternatives are left untouched, preserving existing multiline attribute support (them='...'and multilinev-for="..."test cases still pass).Testing
Added a regression test asserting the extractor recovers
[c~="red"]from the exact reproduction. Verified it fails onmainand passes with the fix; the fullpreset-attributifysuite (17 tests) stays green.Thanks to @alpacaonthehill for the clear minimal reproduction.