Repository navigation
fix(webhook): logs grid search placeholder reflects SKU/user - #408
Merged
navneetkumar-pim-webkul merged 2 commits intoMay 25, 2026
Merged
navneetkumar-pim-webkul merged 2 commits into
navneetkumar-pim-webkul merged 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a UX mismatch in the Admin webhook logs DataGrid by updating the search box placeholder to reflect the actual searchable columns (sku and user) instead of referencing a non-existent code column, and adds a new localized translation key to support the updated placeholder across all Admin locales.
Changes:
- Update
LogsDataGridsearch placeholder key toadmin::app.components.datagrid.toolbar.search_by.sku_or_user. - Add
sku_or_userundercomponents.datagrid.toolbar.search_byacross all Admin locale files. - Add a Pest feature test to guard the placeholder key and ensure the English translation resolves.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php | Updates the webhook logs DataGrid search placeholder translation key to match searchable columns (SKU/user). |
| packages/Webkul/Admin/tests/Feature/Webhook/WebhookLogsSearchPlaceholderTest.php | Adds regression tests covering the placeholder key and English translation resolution. |
| packages/Webkul/Admin/src/Resources/lang/ar_AE/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/ca_ES/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/da_DK/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/de_DE/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/en_AU/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/en_GB/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/en_NZ/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/en_US/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/es_ES/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/es_VE/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/fi_FI/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/fr_FR/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/hi_IN/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/hr_HR/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/id_ID/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/it_IT/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/ja_JP/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/ko_KR/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/mn_MN/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/nl_NL/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/no_NO/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/pl_PL/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/pt_BR/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/pt_PT/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/ro_RO/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/ru_RU/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/sv_SE/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/tl_PH/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/tr_TR/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/uk_UA/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/vi_VN/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/zh_CN/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
| packages/Webkul/Admin/src/Resources/lang/zh_TW/app.php | Adds sku_or_user translation for the DataGrid search placeholder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed The webhook logs grid (
/admin/webhook/settings?logs) showed "Search by code" in the toolbar, but the underlying datagrid only exposesskuanduseras searchable columns — there is nocodecolumn onwebhook_logs, leaving users to guess what "code" referred to.Fix
LogsDataGrid::$searchPlaceholdernow points atadmin::app.components.datagrid.toolbar.search_by.sku_or_user.sku_or_userkey added undercomponents.datagrid.toolbar.search_byin all 33 Admin locale files, each with a native translation.unopim:translations:checkaudit: 224/224 PASS.Test plan
pest—WebhookLogsSearchPlaceholderTest(2 tests guarding the placeholder key + resolved English string)pest— fullAdmin/tests/Feature/Webhook+DataGrid/testssuites greenpint— clean on all touched filesartisan unopim:translations:check— 100% per locale/admin/webhook/settings?logsand verify placeholder reads "Search by SKU or user" (and the localized variant when switching UI language)