Repository navigation
Preselect application locale and currency from .env during reinstallation - #515
Merged
navneetkumar-pim-webkul merged 2 commits intoJun 26, 2026
Conversation
rajpratham1
approved these changes
Jun 20, 2026
rajpratham1
left a comment
rajpratham1
left a comment
There was a problem hiding this comment.
This is a thoughtful UX improvement that solves a genuine usability issue during reinstallation without changing the existing search behavior. The implementation is well scoped, gracefully handles invalid or missing .env values, and is backed by comprehensive tests covering both the prompt behavior and environment value resolution.
navneetkumar-pim-webkul
merged commit Jun 26, 2026
34e16d7
into
unopim:master
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When re-running the installer on an existing instance, the locale and
currency prompts always opened empty — users had to reselect values that
were already configured in .env, risking accidental changes.
Change
The installer now reads the existing APP_LOCALE / APP_CURRENCY from .env and
shows them as the preselected option. Press Enter to keep the current
value, or Backspace to clear and search for a different one. Search behavior
is unchanged.
seeds the current value as the highlighted default; reverts to normal search
on any keypress.
getEnvChoiceDefault() and passes it as the default.
Tests
Added InstallerPreselectEnvChoiceTest covering: keep-on-Enter,
change-via-Backspace, no-default, invalid/stale value, and .env resolution.
Verified end-to-end against the real updateEnvChoice flow.