Skip to content

fix(admin): rebuild admin assets so the remove-model button turns red on hover - #733

Merged
navneetkumar-pim-webkul merged 1 commit into
3.xfrom
fix/rebuild-admin-assets-3.1.2
Sep 24, 2026
Merged

navneetkumar-pim-webkul merged 1 commit into
3.xfrom
fix/rebuild-admin-assets-3.1.2

Conversation

@navneetkumar-pim-webkul

Copy link
Copy Markdown
Collaborator

Issue Reference

N/A — found during the 3.1.2 release readiness check.

Description

#723 added hover:text-danger to the remove-model button on the Magic AI platform form after the last admin asset build (#719), so the compiled stylesheet did not carry the rule and the button never turned red on hover.

This rebuilds the admin theme assets. The only CSS difference is the added hover:text-danger rule and the removal of max-h-[420px], which no source file uses any more. The JS bundle is unchanged.

How To Test This?

  1. Open Configuration > Magic AI > Platforms and edit a non-managed platform.
  2. Hover the "×" next to a model.
  3. The "×" turns red.

Screenshots

N/A — one hover colour.

Checklist

  • vendor/bin/pest passes locally — not run; no PHP changed
  • vendor/bin/pint --test reports no style issues — not run; no PHP changed
  • Tailwind classes are reordered
  • New user-facing strings use translation keys (all 33 locales) — none added
  • Target branch is master — targets 3.x for the 3.1.2 release

Documentation

  • My pull request requires an update on the documentation repository.

… on hover

#723 added hover:text-danger to the Magic AI platform form after the
last asset build, so the compiled stylesheet did not carry the rule.
Copilot AI lite review requested due to automatic review settings September 24, 2026 16:54
@navneetkumar-pim-webkul
navneetkumar-pim-webkul merged commit ce453f3 into 3.x Sep 24, 2026
22 of 23 checks passed
@navneetkumar-pim-webkul
navneetkumar-pim-webkul deleted the fix/rebuild-admin-assets-3.1.2 branch September 24, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed asset changes address the intended hover-style fix with no unresolved issues.

Review effort: Lite
Findings: None

What changed in this PR

Rebuilds admin assets so the Magic AI model removal button turns red on hover.

Changes:

  • Updates the manifest to reference the rebuilt stylesheet.
  • Replaces the superseded CSS bundle.
File Description
public/​themes/​admin/​default/​build/​manifest.json References the rebuilt CSS asset.
public/​themes/​admin/​default/​build/​assets/​app-f6VBAzUI.css Superseded stylesheet removed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants