Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs by gnoff · Pull Request #56809 · vercel/next.js

gnoff · 2023-10-13T18:23:25Z

The latest React canary builds have a few changes that need to be adopted for compatability.

the useFormState and useFormStatus hooks in react-dom and the formData opiont in react-dom/server are no longer prefixed with experimental_
server content (an undocumented React feature) has been removed. Next only had trivial intenral use of this API and did not expose a coherent feature to Next users (no ability to seed context on refetches). It is still possible that some users used the React server context APIs which is why this should go into Next 14.

React upstream changes

ijjk · 2023-10-13T18:26:16Z

Tests Passed

styfle · 2023-10-13T18:27:10Z

In the future, we might want to change this from explicit type to some shared type that matches the caller

socket-security · 2023-10-13T18:32:40Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
scheduler	0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 0.24.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013	None	`+0/-0`	117 kB	react-bot
scheduler	0.0.0-experimental-d900fadbf-20230929...0.24.0-canary-09fbee89d-20231013, 0.24.0-canary-d900fadbf-20230929...0.24.0-canary-09fbee89d-20231013	None	`+0/-0`	117 kB	react-bot
react	0.0.0-experimental-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013	None	`+0/-0`	405 kB	react-bot
react	0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013	None	`+0/-0`	433 kB	react-bot
react-dom	0.0.0-experimental-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...0.0.0-experimental-09fbee89d-20231013	None	`+5/-0`	10.4 MB	react-bot
react-dom	0.0.0-experimental-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013, 18.3.0-canary-d900fadbf-20230929...18.3.0-canary-09fbee89d-20231013	None	`+5/-10`	8.58 MB	react-bot

ijjk · 2023-10-13T20:26:04Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	gnoff/next.js update-react	Change
buildDuration	10.4s	10.4s	N/A
buildDurationCached	6.2s	6.1s	N/A
nodeModulesSize	172 MB	173 MB	⚠️ +632 kB
nextStartRea..uration (ms)	536ms	537ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	gnoff/next.js update-react	Change
199-HASH.js gzip	27.5 kB	27.5 kB	N/A
3f784ff6-HASH.js gzip	50.9 kB	N/A	N/A
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.3 kB	45.3 kB	✓
main-app-HASH.js gzip	254 B	252 B	N/A
main-HASH.js gzip	32.9 kB	32.9 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
3c4a14c2-HASH.js gzip	N/A	53.1 kB	N/A
Overall change	45.5 kB	45.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	gnoff/next.js update-react	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	gnoff/next.js update-react	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.57 kB	2.57 kB	N/A
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.35 kB	4.35 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.64 kB	2.63 kB	N/A
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.08 kB	1.08 kB	✓

Client Build Manifests

	vercel/next.js canary	gnoff/next.js update-react	Change
_buildManifest.js gzip	485 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	gnoff/next.js update-react	Change
index.html gzip	528 B	530 B	N/A
link.html gzip	541 B	542 B	N/A
withRouter.html gzip	523 B	525 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size Overall increase ⚠️

	vercel/next.js canary	gnoff/next.js update-react	Change
edge-ssr.js gzip	93.7 kB	93.7 kB	N/A
page.js gzip	152 kB	154 kB	⚠️ +2.41 kB
Overall change	152 kB	154 kB	⚠️ +2.41 kB

Middleware size

	vercel/next.js canary	gnoff/next.js update-react	Change
middleware-b..fest.js gzip	625 B	622 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	22.5 kB	22.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Diff details

Diff for page.js

Diff too large to display

Diff for 199-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Commit: 6e7be35

styfle · 2023-10-14T15:57:29Z

I converted to a draft since the description said not to merge until 14

- react/react#27513 - react/react#27514 - react/react#27511 - react/react#27508 - react/react#27502 - react/react#27474 - react/react#26789 - react/react#27500 - react/react#27488 - react/react#27458 - react/react#27471 - react/react#27470 - react/react#27464 - react/react#27456 - react/react#27462 - react/react#27461 - react/react#27460 - react/react#27459 - react/react#27454 - react/react#27457 - react/react#27453 - react/react#27401 - react/react#27443 - react/react#27445 - react/react#27364 - react/react#27440 - react/react#27436

…ever fully implemented it anyway. This removes any references to server context APIs (entirely internal) which is now required since the latest React canary no longer exposes these APIs.

…ist in canary and experimental builds without the `experimental_` prefix. This commit updates our docs, examples, and tests to reflect this.

leonaves · 2023-10-22T09:54:13Z

Why are you publishing docs saying this stuff can be used when it's not in stable release??

gnoff requested review from a team, feedthejim, huozhi, ijjk, shuding, timneutkens, wyattjoh and ztanner as code owners October 13, 2023 18:23

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 13, 2023

styfle reviewed Oct 13, 2023

View reviewed changes

styfle previously approved these changes Oct 13, 2023

View reviewed changes

huozhi mentioned this pull request Oct 13, 2023

Update React from d900fadbf to 6f1324395 #56220

Closed

gnoff dismissed styfle’s stale review via 2341b09 October 13, 2023 20:20

gnoff requested a review from a team as a code owner October 13, 2023 20:39

gnoff requested review from Nutlope and ismaelrumzan and removed request for a team October 13, 2023 20:39

ijjk added area: documentation examples Issue was opened via the examples template. labels Oct 13, 2023

gnoff force-pushed the update-react branch 3 times, most recently from 8092f80 to 48d63c9 Compare October 13, 2023 23:34

gnoff changed the title ~~Update React from d900fadbf to 09fbee89d.~~ Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs Oct 13, 2023

styfle approved these changes Oct 14, 2023

View reviewed changes

styfle marked this pull request as draft October 14, 2023 15:56

gnoff added 5 commits October 16, 2023 10:03

Update tests and code to satisfy new React APIs and type changes

79484d2

React is removing Server Context (it was never documented) and Next n…

57e78b1

…ever fully implemented it anyway. This removes any references to server context APIs (entirely internal) which is now required since the latest React canary no longer exposes these APIs.

useFormState and useFormStatus are no longer experimental APIs and ex…

22e1f03

…ist in canary and experimental builds without the `experimental_` prefix. This commit updates our docs, examples, and tests to reflect this.

fix lints

83ff59d

gnoff force-pushed the update-react branch from 48d63c9 to 83ff59d Compare October 16, 2023 17:10

gnoff marked this pull request as ready for review October 16, 2023 17:42

sebmarkbage approved these changes Oct 16, 2023

View reviewed changes

huozhi approved these changes Oct 16, 2023

View reviewed changes

ztanner and others added 5 commits October 16, 2023 14:31

Merge branch 'canary' into update-react

e72fe97

Merge branch 'canary' into update-react

e260dc4

Merge branch 'canary' into update-react

fe987d5

Merge branch 'canary' into update-react

9beb934

Merge branch 'canary' into update-react

6e7be35

ztanner merged commit 0a80017 into vercel:canary Oct 16, 2023

gnoff deleted the update-react branch October 17, 2023 18:01

styfle added the hacktoberfest-accepted label Oct 18, 2023

apostolos mentioned this pull request Oct 24, 2023

Upgrade vendored React #56705

Closed

github-actions Bot added the locked label Nov 5, 2023

github-actions Bot locked as resolved and limited conversation to collaborators Nov 5, 2023

unstubbable added the type: react-sync label Jul 26, 2024

Navigation Menu

Repository navigation

Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs - #56809

Update React from d900fadbf to 09fbee89d. Removes server context and experimental prefix for server action APIs#56809
ztanner merged 10 commits into
vercel:canaryfrom
gnoff:update-react

gnoff commented Oct 13, 2023 •

edited

Loading

Uh oh!

ijjk commented Oct 13, 2023 •

edited

Loading

Uh oh!

styfle Oct 13, 2023

Uh oh!

socket-security Bot commented Oct 13, 2023 •

edited

Loading

Uh oh!

ijjk commented Oct 13, 2023 •

edited

Loading

Uh oh!

styfle commented Oct 14, 2023

Uh oh!

leonaves commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

gnoff commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React upstream changes

Uh oh!

ijjk commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

styfle Oct 13, 2023

Choose a reason for hiding this comment

Uh oh!

socket-security Bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijjk commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

Uh oh!

styfle commented Oct 14, 2023

Uh oh!

leonaves commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gnoff commented Oct 13, 2023 •

edited

Loading

ijjk commented Oct 13, 2023 •

edited

Loading

socket-security Bot commented Oct 13, 2023 •

edited

Loading

ijjk commented Oct 13, 2023 •

edited

Loading