Fix instant-false codemod to run on route segment filenames - #98880
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Tests PassedCommit: 7c8383e |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 873be42ea3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Expose unwanted instant opt-outs in prefixed helper filenames by exercising the production path filter on POSIX and Windows paths. Preserve coverage for route files and compound suffixes.
Require the filename after app directories to start with page., layout., or default. so helper files are left unchanged. Continue accepting compound suffixes without consulting pageExtensions.
03f7999 to
7c8383e
Compare
|
@codex review again |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
devjiwonchoi
changed the title
instant-false codemod to run on route segment filenames
2 participants
Why?
The codemod incorrectly adds
instant = falseto helper files because its matcher matcheslayout.tswithincustom-layout.tsandpage.tsxwithinhomepage.tsx.How?
Require filenames to start with
page.,layout., ordefault., while preserving compound extensions. The codemod does not consultpageExtensions, so files such aspage.test.tsxremain eligible.