Fix root predicates - #98942
Merged
lukesandberg merged 3 commits intoSep 25, 2026
Merged
Fix root predicates#98942lukesandberg merged 3 commits into
lukesandberg merged 3 commits into
Conversation
lukesandberg
added this pull request to stack #98943
September 19, 2026 18:16
Contributor
Tests PassedCommit: a89a10a |
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 19, 2026 18:17
9a92d80 to
22bf86e
Compare
lukesandberg
marked this pull request as ready for review
September 20, 2026 17:32
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 20, 2026 18:40
a9c39a7 to
4a8c9c1
Compare
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 23, 2026 20:52
4a8c9c1 to
c50f2e8
Compare
jimmyhmiller
approved these changes
Sep 23, 2026
lukesandberg
removed this pull request from stack #98943
September 23, 2026 21:45
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 23, 2026 21:45
c50f2e8 to
b756956
Compare
lukesandberg
added this pull request to stack #99126
September 23, 2026 21:45
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 23, 2026 22:23
b756956 to
1a03e0e
Compare
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 24, 2026 06:22
1a03e0e to
c9d4a5a
Compare
lukesandberg
removed this pull request from stack #99126
September 24, 2026 06:27
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 24, 2026 06:27
c9d4a5a to
57b9406
Compare
lukesandberg
added this pull request to stack #99146
September 24, 2026 06:27
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 24, 2026 16:09
57b9406 to
1641fa9
Compare
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
2 times, most recently
from
September 24, 2026 16:44
d95fd68 to
dff1839
Compare
lukesandberg
force-pushed
the
gc-10-75-roots-are-transiently-retained
branch
from
September 25, 2026 00:15
dff1839 to
a89a10a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the definition of GC roots to account for all transient references
There was a categorical mistake in how
uppersandcollectible_dependentswere interpreted. Both of these refer to a task above us and this is it is a reference but the reference might be comming from transient or persistent tasks. This is what kept confusing the 'root' definitionSo the new definition is simply
The old definition expected roots to have no uppers at all, which isn't correct. A
run_oncetask becomes an aggregation root and so the nested persistent tasks reference it as an upper. Those tasks should become gc roots since they are on the transient <--> persistent boundary and the only thing retaining them is references from transient tasks.