Move suspension into operation guard - #99053
Merged
Merged
Conversation
Contributor
Tests PassedCommit: ed869eb |
lukesandberg
approved these changes
Sep 22, 2026
jimmyhmiller
force-pushed
the
jimmym/suspend-on-operation-guard
branch
from
September 23, 2026 14:49
e39d3b2 to
4c7e70b
Compare
Require an active operation guard before decrementing the snapshot coordinator count.
jimmyhmiller
force-pushed
the
jimmym/suspend-on-operation-guard
branch
from
September 23, 2026 16:23
4c7e70b to
ed869eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So in some testing I found a rare error where a child task could take the suspend point, causing it to decrement the counter even though it hadn't incremented it. Move this operation to the guard makes this not impossible (you can still just grab the coordinator) but at least in this code path makes it unlikely you do this. It fixes the bug I found. Discussed this with Luke. We agreed trying to recreate the case in a unit test would probably be a bit overkill.