Skip to content

Turbopack: pass RcStr to AnalyzeIssue - #99166

Merged
mischnic merged 1 commit into
canaryfrom
mischnic/remove-cell-analyzeissue
Sep 24, 2026
Merged

mischnic merged 1 commit into
canaryfrom
mischnic/remove-cell-analyzeissue

Conversation

@mischnic

@mischnic mischnic commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

These were only ever StyledString::Text anyway. So just store the RcStr directly

Simplify the code to fix these lint errors

➜  next.js-other git:(canary) ✗ pnpm sg scan
error[no-map-async-cell]: Using `.map(async |...| { ...cell() })` causes non-deterministic cell order
    ┌─ turbopack/crates/turbopack-core/src/module_graph/mod.rs:766:33
    │    
722 │ ╭               modules
723 │ │                   .iter()
724 │ │                   .map(async |m| {
    │ │ ╭──────────────────────'
    · │ │
766 │ │ │                                 Vc::cell(rcstr!("Module graph is missing an entry point")),
    │ │ │                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    · │ │
798 │ │ │                 })
    │ ╰─│──────────────────'
    │   ╰─────────────────'
    │    
    = You probably want to first try_join() the async computations before wrapping them in a cell.

error[no-map-async-cell]: Using `.map(async |...| { ...cell() })` causes non-deterministic cell order
    ┌─ turbopack/crates/turbopack-core/src/module_graph/mod.rs:767:33
    │      
722 │   ╭               modules
723 │   │                   .iter()
724 │   │                   .map(async |m| {
    │   │ ╭──────────────────────'
    ·   │ │
767 │ ╭ │ │                                 StyledString::Text(rcstr!(
    · │ │ │
771 │ │ │ │                                 .cell(),
    │ ╰─│─│───────────────────────────────────────^
    ·   │ │
798 │   │ │                 })
    │   ╰─│──────────────────'
    │     ╰─────────────────'
    │      
    = You probably want to first try_join() the async computations before wrapping them in a cell.

Error: 2 error(s) found in code.
Help: Scan succeeded and found error level diagnostics in the codebase.

➜  next.js-other git:(canary) ✗ 

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 6b39f99

@mischnic
mischnic force-pushed the mischnic/remove-cell-analyzeissue branch from 7b1d79b to 6b39f99 Compare September 24, 2026 15:10
@mischnic
mischnic requested a review from a team September 24, 2026 15:12
@mischnic
mischnic enabled auto-merge (squash) September 24, 2026 15:26
@mischnic
mischnic merged commit a48eee2 into canary Sep 24, 2026
101 checks passed
@mischnic
mischnic deleted the mischnic/remove-cell-analyzeissue branch September 24, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants