This repository was archived by the owner on Jan 13, 2024. It is now read-only.
ldid: explicitly mark signature as adhoc - #1393
Merged
Merged
Conversation
Contributor
|
Can you explain why this is neccessary? |
Contributor
Author
|
it is needed for macOS Monterey (arm64) |
jesec
approved these changes
Nov 12, 2021
jesec
left a comment
jesec
left a comment
Contributor
There was a problem hiding this comment.
I am able to run the binary (produced with the current flags) on macOS Monterey. That is, this PR is not really neccessary.
Executable=/Users/jc/Sources/pkg/1
Identifier=pkg-macos
Format=Mach-O thin (arm64)
CodeDirectory v=20400 size=389954 flags=0x0(none) hashes=12181+2 location=embedded
./1: no signature
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements count=1 size=128
Nonetheless, I am happy to make the result closer to the codesign utility.
Contributor
Author
|
sorry i mixed it up with iOS 15 (which we don't target), and that doesn't allow JIT anyways so this really isn't necessary |
|
What version of ldid are you using? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.