Skip to content
This repository was archived by the owner on Jan 13, 2024. It is now read-only.

test: rearrange and fix order - #1650

Merged
jesec merged 2 commits into
mainfrom
pr/tests
Jun 2, 2022
Merged

jesec merged 2 commits into
mainfrom
pr/tests

Conversation

@jesec

@jesec jesec commented Jun 1, 2022

Copy link
Copy Markdown
Contributor
test: rearrange and fix order

- we care other tests more than compression, so move it to the back.
  - plus it is really time consuming.
- tests for issues are out-of-order, due to strcmp "1000" < "2".
test: fs-runtime-layer: remove "birthtime" check

This does not make sense since we use the stat() of the executable
for all stat() inside snapshot.

jesec added 2 commits June 1, 2022 11:34
- we care other tests more than compression, so move it to the back.
  - plus it is really time consuming.
- tests for issues are out-of-order, due to strcmp "1000" < "2".
This does not make sense since we use the stat() of the executable
for all stat() inside snapshot.
@jesec
jesec requested a review from robertsLando June 2, 2022 04:18

@robertsLando robertsLando left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesec
jesec merged commit 7c72f3a into main Jun 2, 2022
@jesec
jesec deleted the pr/tests branch June 2, 2022 05:50
gagoar referenced this pull request in gagoar/github-app-installation-token Mar 6, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pkg](https://togithub.com/vercel/pkg) | [`5.7.0` ->
`5.8.0`](https://renovatebot.com/diffs/npm/pkg/5.7.0/5.8.0) |
[![age](https://badges.renovateapi.com/packages/npm/pkg/5.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/pkg/5.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/pkg/5.8.0/compatibility-slim/5.7.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/pkg/5.8.0/confidence-slim/5.7.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/pkg</summary>

### [`v5.8.0`](https://togithub.com/vercel/pkg/releases/tag/5.8.0)

[Compare Source](https://togithub.com/vercel/pkg/compare/5.7.0...5.8.0)

#### Highlights

- Support more language features, including but not limited to
`classPrivateMethods`
([#&#8203;1248](https://togithub.com/vercel/pkg/issues/1248),
[#&#8203;1249](https://togithub.com/vercel/pkg/issues/1249))
- Note: pkg uses Babel to trace dependencies. It does NOT transform your
sources. You should make sure that your code can run on the target
Node.js version.

#### What's Changed

- Bump to vercel/[email protected] by
[@&#8203;jesec](https://togithub.com/jesec) in
[https://github.com/vercel/pkg/pull/1693](https://togithub.com/vercel/pkg/pull/1693)
    -   Add Node 14.20.0, 16.16.0 and 18.5.0 binaries
- https://nodejs.org/en/blog/vulnerability/july-2022-security-releases
- detector: use Babel AST and default plugins by
[@&#8203;jesec](https://togithub.com/jesec) in
[https://github.com/vercel/pkg/pull/1648](https://togithub.com/vercel/pkg/pull/1648)
- test: rearrange and fix order by
[@&#8203;jesec](https://togithub.com/jesec) in
[https://github.com/vercel/pkg/pull/1650](https://togithub.com/vercel/pkg/pull/1650)
- fix: typo in fabricator.ts by
[@&#8203;eltociear](https://togithub.com/eltociear) in
[https://github.com/vercel/pkg/pull/1661](https://togithub.com/vercel/pkg/pull/1661)

#### New Contributors

- [@&#8203;eltociear](https://togithub.com/eltociear) made their first
contribution in
[https://github.com/vercel/pkg/pull/1661](https://togithub.com/vercel/pkg/pull/1661)

**Full Changelog**: vercel/pkg@5.7.0...5.8.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/gagoar/github-app-installation-token).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0My4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants