Repository navigation
Add a PR template - #21321
Closed
chrisbra wants to merge 5 commits into
Closed
Add a PR template#21321chrisbra wants to merge 5 commits into
chrisbra wants to merge 5 commits into
Conversation
Member
Author
|
related: #21318 |
64-bitman
reviewed
Sep 15, 2026
h-east
reviewed
Sep 16, 2026
shaneharper
reviewed
Sep 16, 2026
| - If AI helped you write or investigate the change or test, add a line | ||
| "Supported by AI" to the commit message. | ||
| - If AI wrote the commit itself, add the trailer | ||
| "Co-authored-by: AI" instead. |
Contributor
There was a problem hiding this comment.
I've used "Co-authored-by: Claude ..." in several commits where I'd authored much of the code myself. A co-author is normally understood to be someone - here, something - that wrote part of something.
A line in the commit message body could record when all code changes came from a tool.
jvoisin
reviewed
Sep 16, 2026
Comment on lines
+8
to
+13
| ### What does this change do? | ||
|
|
||
| <!-- | ||
| One or two sentences, please clearly write what problem this PR fixes, | ||
| for visual changes, a before/after screenshot is helpful | ||
| --> |
Contributor
There was a problem hiding this comment.
Shouldn't this be in the commit message?
Member
Author
There was a problem hiding this comment.
yes of course, that's what the Problem/Solution lines is for. But sometimes when reviewing a PR, this makes it clear about the difference.
Signed-off-by: Christian Brabandt <[email protected]>
chrisbra
force-pushed
the
pull-template
branch
from
September 16, 2026 17:53
5426372 to
00f8a53
Compare
Signed-off-by: Christian Brabandt <[email protected]>
shaneharper
reviewed
Sep 17, 2026
zeertzjq
reviewed
Sep 25, 2026
shaneharper
reviewed
Sep 27, 2026
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.