Skip to content

fix compiler warnings from image_sixel.c - #21436

Closed
64-bitman wants to merge 2 commits into
vim:masterfrom
64-bitman:image_warnings
Closed

fix compiler warnings from image_sixel.c#21436
64-bitman wants to merge 2 commits into
vim:masterfrom
64-bitman:image_warnings

Conversation

@64-bitman

@64-bitman 64-bitman commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this change do?

Fix uninitialized compiler warnings

Commit message

Problem:  compiler warnings emitted due to uninitialized use (Tony Mechelynck)
Solution: Make sixel_image8_crop() return a exit code (Foxe Chen).

AI assistance

  • AI involvement is disclosed in the commit message, or no AI was used

Checklist

  • The commit message follows the Problem/Solution form above
  • Signed-off-by: trailer is present (git commit -s), recommended but not required
  • Tests were added, existing tests cover the change, or the change cannot be tested (say why)
  • Documentation under runtime/doc/ was updated, or no update is needed

@64-bitman

64-bitman commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

I am a bit confused by this new PR template, there are some things that only seem relevant to the person merging this PR? (e.g. checklist, commit message).

@64-bitman

64-bitman commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

Oh nevermind I get what it means now

@h-east

h-east commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

There is a CI error.

2 FAILED:
Found errors in Test_indent_of_source_files():
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[639]..function RunTheTest[63]..Test_indent_of_source_files[18]..<SNR>8_ReportError line 2: testdir/../image_sixel.c line 566: tailing spaces
Found errors in Test_source_files():
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[639]..function RunTheTest[63]..Test_source_files[8]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../image_sixel.c line 566: trailing white space
make: *** [Makefile:86: codestyle] Error 1
make: Leaving directory '/home/runner/work/vim/vim/src/testdir'
Error: Process completed with exit code 2.

@64-bitman

64-bitman commented Oct 4, 2026

Copy link
Copy Markdown
Member Author

There is a CI error.

2 FAILED:
Found errors in Test_indent_of_source_files():
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[639]..function RunTheTest[63]..Test_indent_of_source_files[18]..<SNR>8_ReportError line 2: testdir/../image_sixel.c line 566: tailing spaces
Found errors in Test_source_files():
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[639]..function RunTheTest[63]..Test_source_files[8]..<SNR>8_PerformCheck[11]..<SNR>8_ReportError line 2: ../image_sixel.c line 566: trailing white space
make: *** [Makefile:86: codestyle] Error 1
make: Leaving directory '/home/runner/work/vim/vim/src/testdir'
Error: Process completed with exit code 2.

Fixed

@chrisbra

chrisbra commented Oct 5, 2026

Copy link
Copy Markdown
Member

thanks

@chrisbra chrisbra closed this in 03e7afb Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@64-bitman @h-east @chrisbra