Skip to content

Support go modules - #283

Merged
tyru merged 1 commit into
vim-volt:develfrom
hupfdule:modularization
May 26, 2019
Merged

tyru merged 1 commit into
vim-volt:develfrom
hupfdule:modularization

Conversation

@hupfdule

Copy link
Copy Markdown
Contributor
  • Provide go.mod and go.sum
  • Utilize Travis to build with and without modules

- Provide go.mod and go.sum
- Utilize Travis to build with and without modules
@tyru

tyru commented May 3, 2019

Copy link
Copy Markdown
Member

This is what I wanted and what I should do.
Thanks!
After some investigations, I'll look into this.

@tyru

tyru commented May 3, 2019

Copy link
Copy Markdown
Member

Ah, please specify devel branch for the target branch.

@hupfdule
hupfdule changed the base branch from master to devel May 3, 2019 19:32
@hupfdule

hupfdule commented May 3, 2019

Copy link
Copy Markdown
Contributor Author

Ah, please specify devel branch for the target branch.

Damn, I always forget that.

@tyru

tyru commented May 3, 2019

Copy link
Copy Markdown
Member

Yeah I should write it in CONTRIBUTING.md 😅
I hope the default branch in pull request can be changed...

@tyru
tyru merged commit 1cf6582 into vim-volt:devel May 26, 2019
@tyru

tyru commented May 26, 2019

Copy link
Copy Markdown
Member

Sorry for late merge, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants