Repository navigation
Freezes strings - #104
Closed
radville wants to merge 2 commits into
Closed
Freezes strings#104radville wants to merge 2 commits into
radville wants to merge 2 commits into
Conversation
This updates the test fixtures for the updated output highlighters like pigment gives on modern versions. It also removes the deprecated calls to `File.exists?`. These changes together get the test suite passing on modern Ruby versions with modern gems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a deprecation warning for chilled strings merged recently in Ruby: ruby/ruby@12be40a
And with that we started to see the following warning coming from
org-ruby:This makes updates to freezes strings by default and leave others unfrozen where needed in order to maintain functionality with smallest changes possible.