Repository navigation
test: esm runner only link deps when the module is unlinked - #20350
Merged
Merged
Conversation
|
Contributor
|
This PR is packaged and the instant preview is available (22e1787). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@22e1787
yarn add -D webpack@https://pkg.pr.new/webpack@22e1787
pnpm add -D webpack@https://pkg.pr.new/webpack@22e1787 |
hai-x
marked this pull request as ready for review
January 24, 2026 09:41
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
hai-x
force-pushed
the
esm-test-runner
branch
from
January 24, 2026 12:28
5001268 to
15d0288
Compare
alexander-akait
approved these changes
Jan 24, 2026
Member
|
Let's fix tests 😄 |
hai-x
force-pushed
the
esm-test-runner
branch
4 times, most recently
from
January 24, 2026 18:17
4388058 to
f48d47b
Compare
hai-x
force-pushed
the
esm-test-runner
branch
3 times, most recently
from
January 24, 2026 19:38
838620f to
14f9544
Compare
hai-x
force-pushed
the
esm-test-runner
branch
from
January 24, 2026 19:58
14f9544 to
0fd75ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Refactor test runner.
Fixes a module linking error in
https://github.com/webpack/webpack/actions/runs/21312964097/job/61351839265?pr=20346#step:7:73. The issue occurs when the same module is dynamic imported multiple times by different importers. So here we should ensure modules link their dependencies only once.Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No