Skip to content

Remove extra argument from WebAssemblyImportDependency constructor call site - #6882

Merged
sokra merged 2 commits into
webpack:masterfrom
mohsen1:patch-4
Mar 29, 2018
Merged

sokra merged 2 commits into
webpack:masterfrom
mohsen1:patch-4

Conversation

@mohsen1

@mohsen1 mohsen1 commented Mar 28, 2018

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
no

If relevant, link to documentation update:
no

Summary
As part of #6862 I'm proposing fixes to issues TypeScript compiler have found

Does this PR introduce a breaking change?
no

Other information

@ooflorent

Copy link
Copy Markdown
Contributor

Could you fix the formatting here please? You can run yarn pretty-files to reformat the code.

@webpack-bot

Copy link
Copy Markdown
Contributor

@mohsen1 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@webpack-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra
sokra merged commit 3a6edf0 into webpack:master Mar 29, 2018
@sokra

sokra commented Mar 29, 2018

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants