Repository navigation
Use compilation instead of this in ChunkModuleIdRangePlugin - #6954
Merged
Merged
Conversation
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
force-pushed
the
fix/ChunkModuleIdRangePlugin
branch
from
April 12, 2018 08:08
84e2626 to
b715475
Compare
Contributor
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
Contributor
Author
|
@sokra I've fixed other bugs in |
sokra
approved these changes
Apr 12, 2018
Member
|
Thanks for fixing it |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, link to documentation update:
N/A
Summary
Because of the arrow function
thiswas no longer referencing thecompilationwhich was a bug. Since there is no test or documentation about this plugin, I don't know to create a good test case for this. Is this plugin still relevant?Does this PR introduce a breaking change?
no