Repository navigation
Refactor WebpackError to initialize details as undefined - #6974
Merged
Merged
Conversation
27 tasks done
sokra
requested changes
Apr 9, 2018
| Error.captureStackTrace(this, this.constructor); | ||
| } | ||
|
|
||
| get details() {} |
Contributor
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
Contributor
Author
|
@sokra how you assert custom errors? |
sokra
requested changes
Apr 12, 2018
| constructor(message) { | ||
| super(message); | ||
|
|
||
| this.message = message; |
Member
There was a problem hiding this comment.
Is this line even needed? Doesn't the Error constructor do that?
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
sokra
approved these changes
Apr 12, 2018
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
As part of #6862 I'm refactoring the base error class to initialize the
detailsmember so TypeScript is happy about this classDoes this PR introduce a breaking change?
No
Other information