Repository navigation
JSON and Date API usage fixes - #6982
Conversation
| colors.normal("Built at: "); | ||
| colors.normal( | ||
| builtAtDate.toLocaleDateString({ | ||
| day: "2-digit", |
There was a problem hiding this comment.
This options is ignored when a locale is not specified
There was a problem hiding this comment.
pass undefined as locale, which resolves to the default locale
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
| colors.normal("Built at: "); | ||
| colors.normal( | ||
| builtAtDate.toLocaleDateString({ | ||
| day: "2-digit", |
There was a problem hiding this comment.
pass undefined as locale, which resolves to the default locale
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
Thanks @ooflorent! |
|
It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff). A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future). @mohsen1 Please check if this is appliable to your PR and if you can add more test cases. Read the test readme for details how to write test cases. |
|
Thanks |
4 participants
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
As part of #6862 I'm fixing issues that TypeScript has found.
Does this PR introduce a breaking change?
No
Other information