Repository navigation
Make HarmonyAcceptImportDependencyTemplate extend HarmonyImportDependency.Template - #6989
Merged
Merged
Conversation
27 tasks done
Contributor
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
ooflorent
approved these changes
Apr 10, 2018
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Apr 11, 2018
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
This is something that TypeScript is complaining about in #6862
When a static member a subclass does not conform to superclass static member TypeScript throws a type error.
This is a code change that can potentially break things but on the other hand I thought it makes sense to have this class extend superclass static member class
Template.Please let me know if I'm wrong about this.
Does this PR introduce a breaking change?
Potentially
Other information
This might be a TypeScript bug. FYI @DanielRosenwasser @mhegazy