Repository navigation
Avoid type mismatch assignment of number to string in HotModuleReplacementPlugin - #7020
Merged
Merged
Conversation
27 tasks done
ooflorent
approved these changes
Apr 11, 2018
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Apr 11, 2018
Contributor
ooflorent
approved these changes
Apr 12, 2018
sokra
approved these changes
Apr 12, 2018
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
As part of #6862 I'm refactoring this for..in statement to be easier for TypeScript to understand.
Does this PR introduce a breaking change?
No
Other information
No reassigning numbers to strings is good for VMs expectations as well.